Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: courgette/encoded_program.h

Issue 613893002: Fix more MSVC warnings, courgette/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/encoded_program.h
diff --git a/courgette/encoded_program.h b/courgette/encoded_program.h
index a370e3aa0aa5c6e1de3c90343c46e66d054d5ba0..a9208adef18757b2cf8c4fa1de1ac62ddcd971c1 100644
--- a/courgette/encoded_program.h
+++ b/courgette/encoded_program.h
@@ -41,7 +41,7 @@ class EncodedProgram {
// NOTE: If any of these methods ever fail, the EncodedProgram instance
// has failed and should be discarded.
CheckBool AddOrigin(RVA rva) WARN_UNUSED_RESULT;
- CheckBool AddCopy(uint32 count, const void* bytes) WARN_UNUSED_RESULT;
+ CheckBool AddCopy(size_t count, const void* bytes) WARN_UNUSED_RESULT;
Peter Kasting 2014/09/30 00:08:01 More fallout from the EmitBytesInstruction() chang
CheckBool AddRel32(int label_index) WARN_UNUSED_RESULT;
CheckBool AddRel32ARM(uint16 op, int label_index) WARN_UNUSED_RESULT;
CheckBool AddAbs32(int label_index) WARN_UNUSED_RESULT;
@@ -87,6 +87,7 @@ class EncodedProgram {
};
typedef NoThrowBuffer<RVA> RvaVector;
+ typedef NoThrowBuffer<size_t> SizeTVector;
typedef NoThrowBuffer<uint32> UInt32Vector;
typedef NoThrowBuffer<uint8> UInt8Vector;
typedef NoThrowBuffer<OP> OPVector;
@@ -109,7 +110,7 @@ class EncodedProgram {
RvaVector abs32_rva_;
OPVector ops_;
RvaVector origins_;
- UInt32Vector copy_counts_;
+ SizeTVector copy_counts_;
UInt8Vector copy_bytes_;
UInt32Vector rel32_ix_;
UInt32Vector abs32_ix_;

Powered by Google App Engine
This is Rietveld 408576698