Fix more MSVC warnings, courgette/ edition.

courgette/assembly_program.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COURGETTE_ASSEMBLY_PROGRAM_H_
 #define COURGETTE_ASSEMBLY_PROGRAM_H_
 
 #include <map>
 #include <set>
 #include <vector>
@@ skipping 69 matching lines @@
   // Generates an ELF style relocation table for ARM.
   CheckBool EmitElfARMRelocationInstruction() WARN_UNUSED_RESULT;
 
   // Following instruction will be assembled at address 'rva'.
   CheckBool EmitOriginInstruction(RVA rva) WARN_UNUSED_RESULT;
 
   // Generates a single byte of data or machine instruction.
   CheckBool EmitByteInstruction(uint8 byte) WARN_UNUSED_RESULT;
 
   // Generates multiple bytes of data or machine instructions.
-  CheckBool EmitBytesInstruction(const uint8* value, uint32 len)
+  CheckBool EmitBytesInstruction(const uint8* value, size_t len)

[Peter Kasting, 2014/09/30 00:08:01]

Only called by DisassemblerElf32::ParseSimpleRegion().  On trunk that passes a
ptrdiff_t here, but a size_t is more correct (and this CL changes it to size_t).
 It's not instantly clear to me whether downcasting from a size_t to uint32 at
that callsite is safe, but why worry?  Just consistently use size_t and we know
there will be no problems.

       WARN_UNUSED_RESULT;
 
   // Generates 4-byte relative reference to address of 'label'.
   CheckBool EmitRel32(Label* label) WARN_UNUSED_RESULT;
 
   // Generates 4-byte relative reference to address of 'label' for
   // ARM.
   CheckBool EmitRel32ARM(uint16 op, Label* label, const uint8* arm_op,
                          uint16 op_size) WARN_UNUSED_RESULT;
 
@@ skipping 58 matching lines @@
   // We have separate label spaces for addresses referenced by rel32 labels and
   // abs32 labels.  This is somewhat arbitrary.
   RVAToLabel rel32_labels_;
   RVAToLabel abs32_labels_;
 
   DISALLOW_COPY_AND_ASSIGN(AssemblyProgram);
 };
 
 }  // namespace courgette
 #endif  // COURGETTE_ASSEMBLY_PROGRAM_H_