Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 613843002: Clean up SVG rendering API (Closed)

Created:
6 years, 2 months ago by rwlbuis
Modified:
6 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up SVG rendering API Remove some methods that are not being used anymore and move some internal methods to private. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -52 lines) Patch
M Source/core/rendering/svg/RenderSVGContainer.h View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 3 chunks +6 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributes.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributes.cpp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
rwlbuis
PTAL
6 years, 2 months ago (2014-09-29 21:41:19 UTC) #2
pdr.
On 2014/09/29 21:41:19, rwlbuis wrote: > PTAL LGTM
6 years, 2 months ago (2014-09-29 22:19:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613843002/1
6 years, 2 months ago (2014-09-29 22:21:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29364)
6 years, 2 months ago (2014-09-29 23:36:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613843002/1
6 years, 2 months ago (2014-09-30 02:01:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29392)
6 years, 2 months ago (2014-09-30 04:00:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613843002/1
6 years, 2 months ago (2014-09-30 04:01:52 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 04:36:39 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 182884

Powered by Google App Engine
This is Rietveld 408576698