Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2013 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "chrome/renderer/extensions/pepper_request_natives.h" | |
| 6 | |
| 7 #include <string> | |
| 8 | |
| 9 #include "base/logging.h" | |
| 10 #include "base/values.h" | |
| 11 #include "chrome/renderer/extensions/chrome_v8_context.h" | |
| 12 #include "content/public/renderer/v8_value_converter.h" | |
| 13 | |
| 14 namespace extensions { | |
| 15 | |
| 16 PepperRequestNatives::PepperRequestNatives(ChromeV8Context* context) | |
| 17 : ObjectBackedNativeHandler(context) { | |
| 18 RouteFunction( | |
| 19 "SendResponse", | |
| 20 base::Bind(&PepperRequestNatives::SendResponse, base::Unretained(this))); | |
| 21 } | |
| 22 | |
| 23 void PepperRequestNatives::SendResponse( | |
| 24 const v8::FunctionCallbackInfo<v8::Value>& args) { | |
| 25 DCHECK_EQ(3, args.Length()); | |
| 26 DCHECK(args[0]->IsInt32()); | |
| 27 DCHECK(args[1]->IsArray()); | |
| 28 int request_id = args[0]->Int32Value(); | |
| 29 if (args[2]->IsString()) { | |
| 30 context()->pepper_request_proxy()->OnResponseReceived( | |
| 31 request_id, false, base::ListValue(), *v8::String::Utf8Value(args[2])); | |
| 32 return; | |
| 33 } | |
| 34 | |
| 35 scoped_ptr<content::V8ValueConverter> converter( | |
| 36 content::V8ValueConverter::create()); | |
| 37 scoped_ptr<const base::Value> result( | |
| 38 converter->FromV8Value(args[1], context()->v8_context())); | |
| 39 DCHECK(result); | |
|
not at google - send to devlin
2013/12/10 22:22:16
nothing to change here, but fwiw:
My distaste for
| |
| 40 const base::ListValue* result_list = NULL; | |
| 41 CHECK(result->GetAsList(&result_list)); | |
| 42 context()->pepper_request_proxy()->OnResponseReceived( | |
| 43 request_id, true, *result_list, ""); | |
| 44 } | |
| 45 | |
| 46 } // namespace extensions | |
| OLD | NEW |