Source/core/rendering/RenderRuby.h - Issue 613783002: Smaller vtbls in RenderObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderRuby.h

Issue 613783002: Smaller vtbls in RenderObject (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: RenderObject: Cut down vtbls a bit Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderRuby.h

diff --git a/Source/core/rendering/RenderRuby.h b/Source/core/rendering/RenderRuby.h

index 2058cad94885639f08f914d849a06d9f9cae5c9e..8f1453c29c80653e9ae1f0a508856d0491217318 100644

--- a/Source/core/rendering/RenderRuby.h

+++ b/Source/core/rendering/RenderRuby.h

@@ -63,7 +63,7 @@ protected:

virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE;

private:

- virtual bool isRuby() const OVERRIDE { return true; }

+ virtual bool isOfType(RenderObjectType type) const OVERRIDE { return type == RenderObjectRuby || RenderInline::isOfType(type); }

virtual const char* renderName() const OVERRIDE { return "RenderRuby (inline)"; }

virtual bool createsAnonymousWrapper() const OVERRIDE { return true; }

};

@@ -81,7 +81,7 @@ protected:

virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE;

private:

- virtual bool isRuby() const OVERRIDE { return true; }

+ virtual bool isOfType(RenderObjectType type) const OVERRIDE { return type == RenderObjectRuby || RenderBlockFlow::isOfType(type); }

virtual const char* renderName() const OVERRIDE { return "RenderRuby (block)"; }

virtual bool createsAnonymousWrapper() const OVERRIDE { return true; }

virtual void removeLeftoverAnonymousBlock(RenderBlock*) OVERRIDE { ASSERT_NOT_REACHED(); }