Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: Source/core/rendering/RenderRuby.h

Issue 613783002: Smaller vtbls in RenderObject (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase better. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderReplica.h ('k') | Source/core/rendering/RenderRubyBase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 RenderRubyAsInline(Element*); 56 RenderRubyAsInline(Element*);
57 virtual ~RenderRubyAsInline(); 57 virtual ~RenderRubyAsInline();
58 58
59 virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) ov erride; 59 virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) ov erride;
60 virtual void removeChild(RenderObject* child) override; 60 virtual void removeChild(RenderObject* child) override;
61 61
62 protected: 62 protected:
63 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) ov erride; 63 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) ov erride;
64 64
65 private: 65 private:
66 virtual bool isRuby() const override { return true; } 66 virtual bool isOfType(RenderObjectType type) const override { return type == RenderObjectRuby || RenderInline::isOfType(type); }
67 virtual const char* renderName() const override { return "RenderRuby (inline )"; } 67 virtual const char* renderName() const override { return "RenderRuby (inline )"; }
68 virtual bool createsAnonymousWrapper() const override { return true; } 68 virtual bool createsAnonymousWrapper() const override { return true; }
69 }; 69 };
70 70
71 // <ruby> when used as 'display:block' or 'display:inline-block' 71 // <ruby> when used as 'display:block' or 'display:inline-block'
72 class RenderRubyAsBlock final : public RenderBlockFlow { 72 class RenderRubyAsBlock final : public RenderBlockFlow {
73 public: 73 public:
74 RenderRubyAsBlock(Element*); 74 RenderRubyAsBlock(Element*);
75 virtual ~RenderRubyAsBlock(); 75 virtual ~RenderRubyAsBlock();
76 76
77 virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) ov erride; 77 virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) ov erride;
78 virtual void removeChild(RenderObject* child) override; 78 virtual void removeChild(RenderObject* child) override;
79 79
80 protected: 80 protected:
81 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) ov erride; 81 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) ov erride;
82 82
83 private: 83 private:
84 virtual bool isRuby() const override { return true; } 84 virtual bool isOfType(RenderObjectType type) const override { return type == RenderObjectRuby || RenderBlockFlow::isOfType(type); }
85 virtual const char* renderName() const override { return "RenderRuby (block) "; } 85 virtual const char* renderName() const override { return "RenderRuby (block) "; }
86 virtual bool createsAnonymousWrapper() const override { return true; } 86 virtual bool createsAnonymousWrapper() const override { return true; }
87 virtual void removeLeftoverAnonymousBlock(RenderBlock*) override { ASSERT_NO T_REACHED(); } 87 virtual void removeLeftoverAnonymousBlock(RenderBlock*) override { ASSERT_NO T_REACHED(); }
88 }; 88 };
89 89
90 } // namespace blink 90 } // namespace blink
91 91
92 #endif // RenderRuby_h 92 #endif // RenderRuby_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderReplica.h ('k') | Source/core/rendering/RenderRubyBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698