Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: Source/core/rendering/RenderMedia.h

Issue 613783002: Smaller vtbls in RenderObject (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase better. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderListMarker.h ('k') | Source/core/rendering/RenderMenuList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 void slowLastChild() const WTF_DELETED_FUNCTION; 46 void slowLastChild() const WTF_DELETED_FUNCTION;
47 47
48 const RenderObjectChildList* children() const { return &m_children; } 48 const RenderObjectChildList* children() const { return &m_children; }
49 RenderObjectChildList* children() { return &m_children; } 49 RenderObjectChildList* children() { return &m_children; }
50 50
51 HTMLMediaElement* mediaElement() const; 51 HTMLMediaElement* mediaElement() const;
52 52
53 protected: 53 protected:
54 virtual void layout() override; 54 virtual void layout() override;
55 55
56 virtual bool isOfType(RenderObjectType type) const override { return type == RenderObjectMedia || RenderImage::isOfType(type); }
57
56 private: 58 private:
57 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); } 59 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); }
58 virtual const RenderObjectChildList* virtualChildren() const override final { return children(); } 60 virtual const RenderObjectChildList* virtualChildren() const override final { return children(); }
59 61
60 virtual LayerType layerTypeRequired() const override { return NormalLayer; } 62 virtual LayerType layerTypeRequired() const override { return NormalLayer; }
61 63
62 // FIXME: RenderMedia::layout makes assumptions about what children are allo wed 64 // FIXME: RenderMedia::layout makes assumptions about what children are allo wed
63 // so we can't support generated content. 65 // so we can't support generated content.
64 virtual bool canHaveGeneratedChildren() const override final { return false; } 66 virtual bool canHaveGeneratedChildren() const override final { return false; }
65 virtual bool canHaveChildren() const override final { return true; } 67 virtual bool canHaveChildren() const override final { return true; }
66 68
67 virtual const char* renderName() const override { return "RenderMedia"; } 69 virtual const char* renderName() const override { return "RenderMedia"; }
68 virtual bool isMedia() const override final { return true; }
69 virtual bool isImage() const override final { return false; } 70 virtual bool isImage() const override final { return false; }
70 virtual void paintReplaced(PaintInfo&, const LayoutPoint&) override; 71 virtual void paintReplaced(PaintInfo&, const LayoutPoint&) override;
71 72
72 RenderObjectChildList m_children; 73 RenderObjectChildList m_children;
73 }; 74 };
74 75
75 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMedia, isMedia()); 76 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMedia, isMedia());
76 77
77 } // namespace blink 78 } // namespace blink
78 79
79 #endif // RenderMedia_h 80 #endif // RenderMedia_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderListMarker.h ('k') | Source/core/rendering/RenderMenuList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698