Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

Issue 613763005: closure: update from closure compiler's src and rebuild runner.jar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebuild runner, too Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/closure_compiler/runner/runner.jar ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java
diff --git a/third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java b/third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java
index be8da2eaa45fe5f55389941158795b06da76a36e..d89782358003410cb798aa6b43b5ebd596ba2d24 100644
--- a/third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java
+++ b/third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java
@@ -123,8 +123,8 @@ public class ChromePass extends AbstractPostOrderCallback implements CompilerPas
Node property = call.getChildAtIndex(2);
- Node getPropNode = NodeUtil.newQualifiedNameNode(compiler.getCodingConvention(),
- target + "." + property.getString()).srcrefTree(call);
+ Node getPropNode = NodeUtil.newQName(
+ compiler, target + "." + property.getString()).srcrefTree(call);
if (callee.matchesQualifiedName(CR_DEFINE_PROPERTY)) {
setJsDocWithType(getPropNode, getTypeByCrPropertyKind(call.getChildAtIndex(3)));
@@ -233,8 +233,7 @@ public class ChromePass extends AbstractPostOrderCallback implements CompilerPas
if (field.endsWith("_")) {
String publicName = field.substring(0, field.length() - 1);
if (publicAPIStrings.contains(publicName)) {
- Node methodDeclaration = NodeUtil.newQualifiedNameNode(
- compiler.getCodingConvention(), className + "." + publicName);
+ Node methodDeclaration = NodeUtil.newQName(compiler, className + "." + publicName);
if (jsDocSourceNode.getJSDocInfo() != null) {
methodDeclaration.setJSDocInfo(jsDocSourceNode.getJSDocInfo());
scope.addChildBefore(
@@ -448,8 +447,8 @@ public class ChromePass extends AbstractPostOrderCallback implements CompilerPas
private Node buildQualifiedName(Node internalName) {
String externalName = this.exports.get(internalName.getString());
- return NodeUtil.newQualifiedNameNode(compiler.getCodingConvention(),
- this.namespaceName + "." + externalName).srcrefTree(internalName);
+ return NodeUtil.newQName(compiler, this.namespaceName + "." + externalName).srcrefTree(
+ internalName);
}
}
}
« no previous file with comments | « third_party/closure_compiler/runner/runner.jar ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698