Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 613763005: closure: update from closure compiler's src and rebuild runner.jar (Closed)

Created:
6 years, 2 months ago by Dan Beam
Modified:
6 years, 2 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebuild runner, too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -7 lines) Patch
M third_party/closure_compiler/bump_compiler_version View 1 2 chunks +5 lines, -1 line 0 comments Download
M third_party/closure_compiler/compiler/compiler.jar View Binary file 0 comments Download
M third_party/closure_compiler/externs/chrome_extensions.js View 1 chunk +155 lines, -0 lines 0 comments Download
M third_party/closure_compiler/runner/runner.jar View 1 Binary file 0 comments Download
M third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
Dan Beam
6 years, 2 months ago (2014-09-30 00:29:46 UTC) #2
Tyler Breisacher (Chromium)
Did you also update compiler.jar by building from source? Or is it just chrome_extensions.js that's ...
6 years, 2 months ago (2014-09-30 00:32:02 UTC) #3
Dan Beam
On 2014/09/30 00:32:02, Tyler Breisacher (Chromium) wrote: > Did you also update compiler.jar by building ...
6 years, 2 months ago (2014-09-30 00:34:06 UTC) #4
Tyler Breisacher (Chromium)
Cool. It might be useful if that script also created the CL and pre-populated it ...
6 years, 2 months ago (2014-09-30 00:37:39 UTC) #5
Tyler Breisacher (Chromium)
On 2014/09/30 00:37:39, Tyler Breisacher (Chromium) wrote: > Cool. It might be useful if that ...
6 years, 2 months ago (2014-09-30 00:38:02 UTC) #6
Dan Beam
On 2014/09/30 00:38:02, Tyler Breisacher (Chromium) wrote: > On 2014/09/30 00:37:39, Tyler Breisacher (Chromium) wrote: ...
6 years, 2 months ago (2014-09-30 00:40:03 UTC) #7
Vitaly Pavlenko
lgtm lgtm
6 years, 2 months ago (2014-09-30 00:43:41 UTC) #8
Tyler Breisacher (Chromium)
On 2014/09/30 00:40:03, Dan Beam wrote: > On 2014/09/30 00:38:02, Tyler Breisacher (Chromium) wrote: > ...
6 years, 2 months ago (2014-09-30 00:44:16 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5ec01d81da02d1482f9f30ca5ab22d3fc190a953 Cr-Commit-Position: refs/heads/master@{#297333}
6 years, 2 months ago (2014-09-30 01:40:26 UTC) #10
Dan Beam
6 years, 2 months ago (2014-09-30 01:40:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5ec01d81da02d1482f9f30ca5ab22d3fc190a953 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698