Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 613753003: Fix TooltipAura initial sizing. (Closed)

Created:
6 years, 2 months ago by msw
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+corewm_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix TooltipAura initial sizing. r296874 regressed initial tooltip sizing on Aura. (Widget::SetContentsView sizes the view to the widget) Reorder the View sizing to after the Widget init. BUG=418456 TEST=The first Linux Aura tooltip is sized correctly. R=sky@chromium.org Committed: https://crrev.com/a5cdf5ead358ca6ae98deadafc99ddaa06465e23 Cr-Commit-Position: refs/heads/master@{#297281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/corewm/tooltip_aura.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 2 months ago (2014-09-29 20:57:08 UTC) #3
sky
LGTM
6 years, 2 months ago (2014-09-29 21:24:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613753003/1
6 years, 2 months ago (2014-09-29 21:25:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6969e6c3e2404dacef26c0d6de97cdbcbce6dbab
6 years, 2 months ago (2014-09-29 21:59:50 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 22:03:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5cdf5ead358ca6ae98deadafc99ddaa06465e23
Cr-Commit-Position: refs/heads/master@{#297281}

Powered by Google App Engine
This is Rietveld 408576698