Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 613693003: Disable the AccessibilityDl test due to failures on bot. (Closed)

Created:
6 years, 2 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable the AccessibilityDl test due to failures on bot. NOTRY=true BUG=418600 Committed: https://crrev.com/090de747a4ff621c8d432c74a0b5f9da6692e816 Cr-Commit-Position: refs/heads/master@{#297186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Fabrice (no longer in Chrome)
Sample failure: https://chromegw.corp.google.com/i/chromium.webkit/builders/Android%20Tests%20(dbg)/builds/21838/steps/content_browsertests/logs/stdio Disabling test for now.
6 years, 2 months ago (2014-09-29 16:04:01 UTC) #2
ppi
lgtm
6 years, 2 months ago (2014-09-29 16:06:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613693003/1
6 years, 2 months ago (2014-09-29 16:08:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as bd1fdfa1c21b86f9ab960496356d1a98a993bdc8
6 years, 2 months ago (2014-09-29 16:08:46 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/090de747a4ff621c8d432c74a0b5f9da6692e816 Cr-Commit-Position: refs/heads/master@{#297186}
6 years, 2 months ago (2014-09-29 16:09:23 UTC) #7
David Tseng
6 years, 2 months ago (2014-09-29 22:33:49 UTC) #8
Not lg. This test should only have been disabled on Android?

On Mon, Sep 29, 2014 at 9:04 AM, <fdegans@chromium.org> wrote:

> Reviewers: aboxhall_ooo_until_oct_6, dmazzoni, David Tseng, ppi,
>
> Message:
> Sample failure:
> https://chromegw.corp.google.com/i/chromium.webkit/
> builders/Android%20Tests%20(dbg)/builds/21838/steps/
> content_browsertests/logs/stdio
> Disabling test for now.
>
> Description:
> Disable the AccessibilityDl test due to failures on bot.
>
> BUG=418600
>
> Please review this at https://codereview.chromium.org/613693003/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+2, -1 lines):
>   M content/browser/accessibility/dump_accessibility_tree_browsertest.cc
>
>
> Index: content/browser/accessibility/dump_accessibility_tree_
> browsertest.cc
> diff --git
a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
> b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
> index 9d6f2001465356e463c5b97e8ddadac7cb1e6635..
> 4a5e9559bc8ac634610e3bfc96e9899ba180f5a5 100644
> --- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
> +++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
> @@ -523,7 +523,8 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
> AccessibilityDiv) {
>    RunTest(FILE_PATH_LITERAL("div.html"));
>  }
>
> -IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityDl) {
> +// crbug.com/418600
> +IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
> DISABLED_AccessibilityDl) {
>    RunTest(FILE_PATH_LITERAL("dl.html"));
>  }
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698