Add TCP socket mojo interfaces

mojo/services/public/interfaces/network/tcp_socket.mojom

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import "mojo/services/public/interfaces/network/net_address.mojom"
+import "mojo/services/public/interfaces/network/network_error.mojom"
+
+module mojo {
+
+interface TCPSocket {

[yzshen1, 2014/09/30 00:21:52]

Do we need a Bind() function here?

+  Connect(NetAddress addr,
+          handle<data_pipe_consumer> send_stream,
+          handle<data_pipe_producer> receive_stream) =>
+      (NetworkError result,
+       NetAddress local_address,

[yzshen1, 2014/09/30 00:21:52]

you might want to use NetAddress? here, so that it is okay to return NULL on
failure.

(? means nullable, nullable/non-nullable is enforced during message validation.)

+       NetAddress remote_address);
+
+  // Closes the connection. If Close() is not called, the connection will be
+  // implicitly closes when the TCPSocket has been deleted.

[viettrungluu, 2014/09/29 23:50:14]

"deleted"?

+  Close();

[viettrungluu, 2014/09/29 23:50:14]

Is this really necessary at all?

In general, this interface seems kind of broken. It conflates two things: the
ability to make connections and the connection itself.

(E.g., what happens if you call Connect() twice?)

+
+  // Controls whether small writes are coalesced to make TCP segments, and
+  // instead delivers data immediately. The default value is true (coalescing
+  // enabled).
+  SetCoaleseWrites(bool coalesce);
+};
+
+}