Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1696)

Issue 613683004: Move html.height=100% from uber.css to chrome_shared.css. (Closed)

Created:
6 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move html.height=100% from uber.css to chrome_shared.css. Now settings page from Chrome OS does not apply uber.css. BUG=178819, 412272 Committed: https://crrev.com/83cbc0eb332701e4cf15061326a129a0155f02b4 Cr-Commit-Position: refs/heads/master@{#297493}

Patch Set 1 #

Patch Set 2 : Mon Sep 29 12:43:24 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/uber/uber.css View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/webui/resources/css/chrome_shared.css View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Vitaly Buka (NO REVIEWS)
6 years, 2 months ago (2014-09-29 19:43:58 UTC) #2
Vitaly Buka (NO REVIEWS)
+michaelpg
6 years, 2 months ago (2014-09-29 19:48:19 UTC) #4
michaelpg
lgtm
6 years, 2 months ago (2014-09-29 20:01:20 UTC) #5
Dan Beam
lgtm
6 years, 2 months ago (2014-09-30 19:48:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613683004/20001
6 years, 2 months ago (2014-09-30 19:51:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 229898db5bad42491366821245ac98a30420a15c
6 years, 2 months ago (2014-09-30 20:37:54 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 20:38:34 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83cbc0eb332701e4cf15061326a129a0155f02b4
Cr-Commit-Position: refs/heads/master@{#297493}

Powered by Google App Engine
This is Rietveld 408576698