[turbofan] Some javascript operators are globally shared singletons.

src/compiler/js-builtin-reducer-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/graph-unittest.h"
 #include "src/compiler/js-builtin-reducer.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/node-properties-inl.h"
 #include "src/compiler/typer.h"
 #include "testing/gmock-support.h"
@@ skipping 51 matching lines @@
 // -----------------------------------------------------------------------------
 // Math.abs
 
 
 TEST_F(JSBuiltinReducerTest, MathAbs) {
   Handle<JSFunction> f(isolate()->context()->math_abs_fun());
 
   TRACED_FOREACH(Type*, t0, kNumberTypes) {
     Node* p0 = Parameter(t0, 0);
     Node* fun = HeapConstant(Unique<HeapObject>::CreateUninitialized(f));
-    Node* call = graph()->NewNode(javascript()->Call(3, NO_CALL_FUNCTION_FLAGS),
-                                  fun, UndefinedConstant(), p0);
+    Node* call =
+        graph()->NewNode(javascript()->CallFunction(
+                             CallFunctionParameters(3, NO_CALL_FUNCTION_FLAGS)),
+                         fun, UndefinedConstant(), p0);
     Reduction r = Reduce(call);
 
     if (t0->Is(Type::Unsigned32())) {
       ASSERT_TRUE(r.Changed());
       EXPECT_THAT(r.replacement(), p0);
     } else {
       Capture<Node*> branch;
       ASSERT_TRUE(r.Changed());
       EXPECT_THAT(
           r.replacement(),
@@ skipping 11 matching lines @@
 // -----------------------------------------------------------------------------
 // Math.sqrt
 
 
 TEST_F(JSBuiltinReducerTest, MathSqrt) {
   Handle<JSFunction> f(isolate()->context()->math_sqrt_fun());
 
   TRACED_FOREACH(Type*, t0, kNumberTypes) {
     Node* p0 = Parameter(t0, 0);
     Node* fun = HeapConstant(Unique<HeapObject>::CreateUninitialized(f));
-    Node* call = graph()->NewNode(javascript()->Call(3, NO_CALL_FUNCTION_FLAGS),
-                                  fun, UndefinedConstant(), p0);
+    Node* call =
+        graph()->NewNode(javascript()->CallFunction(
+                             CallFunctionParameters(3, NO_CALL_FUNCTION_FLAGS)),
+                         fun, UndefinedConstant(), p0);
     Reduction r = Reduce(call);
 
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsFloat64Sqrt(p0));
   }
 }
 
 
 // -----------------------------------------------------------------------------
 // Math.max
 
 
 TEST_F(JSBuiltinReducerTest, MathMax0) {
   Handle<JSFunction> f(isolate()->context()->math_max_fun());
 
   Node* fun = HeapConstant(Unique<HeapObject>::CreateUninitialized(f));
-  Node* call = graph()->NewNode(javascript()->Call(2, NO_CALL_FUNCTION_FLAGS),
-                                fun, UndefinedConstant());
+  Node* call =
+      graph()->NewNode(javascript()->CallFunction(
+                           CallFunctionParameters(2, NO_CALL_FUNCTION_FLAGS)),
+                       fun, UndefinedConstant());
   Reduction r = Reduce(call);
 
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsNumberConstant(-V8_INFINITY));
 }
 
 
 TEST_F(JSBuiltinReducerTest, MathMax1) {
   Handle<JSFunction> f(isolate()->context()->math_max_fun());
 
   TRACED_FOREACH(Type*, t0, kNumberTypes) {
     Node* p0 = Parameter(t0, 0);
     Node* fun = HeapConstant(Unique<HeapObject>::CreateUninitialized(f));
-    Node* call = graph()->NewNode(javascript()->Call(3, NO_CALL_FUNCTION_FLAGS),
-                                  fun, UndefinedConstant(), p0);
+    Node* call =
+        graph()->NewNode(javascript()->CallFunction(
+                             CallFunctionParameters(3, NO_CALL_FUNCTION_FLAGS)),
+                         fun, UndefinedConstant(), p0);
     Reduction r = Reduce(call);
 
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), p0);
   }
 }
 
 
 TEST_F(JSBuiltinReducerTest, MathMax2) {
   Handle<JSFunction> f(isolate()->context()->math_max_fun());
 
   TRACED_FOREACH(Type*, t0, kNumberTypes) {
     TRACED_FOREACH(Type*, t1, kNumberTypes) {
       Node* p0 = Parameter(t0, 0);
       Node* p1 = Parameter(t1, 1);
       Node* fun = HeapConstant(Unique<HeapObject>::CreateUninitialized(f));
       Node* call =
-          graph()->NewNode(javascript()->Call(4, NO_CALL_FUNCTION_FLAGS), fun,
-                           UndefinedConstant(), p0, p1);
+          graph()->NewNode(javascript()->CallFunction(CallFunctionParameters(
+                               4, NO_CALL_FUNCTION_FLAGS)),
+                           fun, UndefinedConstant(), p0, p1);
       Reduction r = Reduce(call);
 
       if (t0->Is(Type::Integral32()) && t1->Is(Type::Integral32())) {
         Capture<Node*> branch;
         ASSERT_TRUE(r.Changed());
         EXPECT_THAT(
             r.replacement(),
             IsPhi(kMachNone, p1, p0,
                   IsMerge(IsIfTrue(CaptureEq(&branch)),
                           IsIfFalse(AllOf(CaptureEq(&branch),
@@ skipping 14 matching lines @@
 
 TEST_F(JSBuiltinReducerTest, MathImul) {
   Handle<JSFunction> f(isolate()->context()->math_imul_fun());
 
   TRACED_FOREACH(Type*, t0, kNumberTypes) {
     TRACED_FOREACH(Type*, t1, kNumberTypes) {
       Node* p0 = Parameter(t0, 0);
       Node* p1 = Parameter(t1, 1);
       Node* fun = HeapConstant(Unique<HeapObject>::CreateUninitialized(f));
       Node* call =
-          graph()->NewNode(javascript()->Call(4, NO_CALL_FUNCTION_FLAGS), fun,
-                           UndefinedConstant(), p0, p1);
+          graph()->NewNode(javascript()->CallFunction(CallFunctionParameters(
+                               4, NO_CALL_FUNCTION_FLAGS)),
+                           fun, UndefinedConstant(), p0, p1);
       Reduction r = Reduce(call);
 
       if (t0->Is(Type::Integral32()) && t1->Is(Type::Integral32())) {
         ASSERT_TRUE(r.Changed());
         EXPECT_THAT(r.replacement(), IsInt32Mul(p0, p1));
       } else {
         ASSERT_FALSE(r.Changed());
         EXPECT_EQ(IrOpcode::kJSCallFunction, call->opcode());
       }
     }
@@ skipping 10 matching lines @@
       JSObject::GetProperty(isolate()->global_object(),
                             isolate()->factory()->NewStringFromAsciiChecked(
                                 "Math")).ToHandleChecked();
   Handle<JSFunction> f = Handle<JSFunction>::cast(
       JSObject::GetProperty(m, isolate()->factory()->NewStringFromAsciiChecked(
                                    "fround")).ToHandleChecked());
 
   TRACED_FOREACH(Type*, t0, kNumberTypes) {
     Node* p0 = Parameter(t0, 0);
     Node* fun = HeapConstant(Unique<HeapObject>::CreateUninitialized(f));
-    Node* call = graph()->NewNode(javascript()->Call(3, NO_CALL_FUNCTION_FLAGS),
-                                  fun, UndefinedConstant(), p0);
+    Node* call =
+        graph()->NewNode(javascript()->CallFunction(
+                             CallFunctionParameters(3, NO_CALL_FUNCTION_FLAGS)),
+                         fun, UndefinedConstant(), p0);
     Reduction r = Reduce(call);
 
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsTruncateFloat64ToFloat32(p0));
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8