Chromium Code Reviews Chromium Code Reviews
Issue
613673004:
Revert of Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (Closed)
DescriptionRevert of Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (patchset #1 id:1 of https://codereview.chromium.org/609033002/)
Reason for revert:
scoped_ptr nullptr support was un-reverted.
Original issue's description:
> Revert of Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}. (patchset #2 id:20001 of https://codereview.chromium.org/610083002/)
>
> Reason for revert:
> scoped_ptr nullptr support was reverted.
>
> Original issue's description:
> > Mojo: Convert some scoped_ptr<...>(new ...) to make_scoped_ptr(new ...) in mojo/{embedder,system}.
> >
> > R=jamesr@chromium.org
> >
> > Committed: https://crrev.com/a60566701028a7344d17826076780eeb84b63052
> > Cr-Commit-Position: refs/heads/master@{#297095}
>
> TBR=jamesr@chromium.org,viettrungluu@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/3f8f6ea2347da4437dfd56b567c7daddfb9d8940
> Cr-Commit-Position: refs/heads/master@{#297108}
TBR=jamesr@chromium.org,dcheng@chromium.org
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/b2ea46474008a2569ffea10301c5d7e93b66bd5d
Cr-Commit-Position: refs/heads/master@{#297192}
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 1 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
