Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 613653005: Revert of Rebaseline for findbugs for Android. (Closed)

Created:
6 years, 2 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 2 months ago
Reviewers:
Yaron, ppi
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Rebaseline for findbugs for Android. (patchset #1 id:1 of https://codereview.chromium.org/611013002/) Reason for revert: This has created issues in other bots: https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder%20(dbg)/builds/66548/steps/findbugs/logs/stdio Looks like a different configuration is used on different bots, yielding a different output. Reverting for now. Original issue's description: > Rebaseline for findbugs for Android. > > BUG=418549 > NOTRY=true > > Committed: https://crrev.com/26fb9711a189ed3c49ae90873981e074c38534b0 > Cr-Commit-Position: refs/heads/master@{#297165} TBR=yfriedman@chromium.org,ppi@chromium.org NOTREECHECKS=true NOTRY=true BUG=418549 Committed: https://crrev.com/2f3af55b7e03ca1008240bc42207872cb6498c10 Cr-Commit-Position: refs/heads/master@{#297170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Fabrice (no longer in Chrome)
Created Revert of Rebaseline for findbugs for Android.
6 years, 2 months ago (2014-09-29 14:34:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613653005/1
6 years, 2 months ago (2014-09-29 14:35:55 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-09-29 14:35:56 UTC) #4
ppi
lgtm
6 years, 2 months ago (2014-09-29 14:36:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613653005/1
6 years, 2 months ago (2014-09-29 14:37:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 224c1c6555c572ea920f83e14e5b72d2d34eec6d
6 years, 2 months ago (2014-09-29 14:38:30 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 14:39:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f3af55b7e03ca1008240bc42207872cb6498c10
Cr-Commit-Position: refs/heads/master@{#297170}

Powered by Google App Engine
This is Rietveld 408576698