Issue 613653004: Show the serial number of the device in the version string if available.

Issue 613653004: Show the serial number of the device in the version string if available. (Closed)

Created:
6 years, 2 months ago by pastarmovj

Modified:
6 years, 2 months ago

Reviewers:
ygorshenin1

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Show the serial number of the device in the version string if available. BUG=216422 TEST=manual. Committed: https://crrev.com/54311ec8b742e61357aaf912e6ce3a6177c46e87 Cr-Commit-Position: refs/heads/master@{#297160}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -3 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/version_info_updater.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/version_info_updater.cc	View	3 chunks	+16 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

pastarmovj

Hi Yuri, can you please review this CL. It adds the SN of the device ...

6 years, 2 months ago (2014-09-29 11:28:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613653004/1

6 years, 2 months ago (2014-09-29 11:40:42 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 4ea5cf5c24805d278512ec3bdc224e8265387336

6 years, 2 months ago (2014-09-29 12:19:57 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 12:20:27 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/54311ec8b742e61357aaf912e6ce3a6177c46e87
Cr-Commit-Position: refs/heads/master@{#297160}