Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 613593002: webtry: Only create sqlite3 tables if they don't exist yet. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
jcgregorio, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

webtry: Only create sqlite3 tables if they don't exist yet. Otherwise it will through an error like the following: 2014/09/28 21:22:24 Info: status creating sqlite table for sources: "table source_images already exists" 2014/09/28 21:22:24 Info: status creating sqlite table for webtry: "table webtry already exists" 2014/09/28 21:22:24 Info: status creating sqlite table for workspace: "table workspace already exists" 2014/09/28 21:22:24 Info: status creating sqlite table for workspace try: "table workspacetry already exists" To test locally the following was done: $ ./gyp_skia gyp/webtry.gyp gyp/most.gyp -Dskia_gpu=0 $ ninja -C out/Debug webtry $ cd experimental/webtry $ go get -d $ go build webtry.go $ ./webtry $ google-chrome http://localhost:8000 Expected: see no more the above messages. BUG=None TEST=see above R=jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/fffa16cc277c286687b0f42a7cc87217dd94938e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M experimental/webtry/webtry.go View 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tfarina
6 years, 2 months ago (2014-09-29 00:31:32 UTC) #1
jcgregorio
Adding stephana as he has plans regarding our handling of SQL.
6 years, 2 months ago (2014-09-29 15:08:21 UTC) #4
tfarina
Ping? Remember that this is 'webtry' only. Not 'perf' for the moment since Stephan is ...
6 years, 2 months ago (2014-09-30 13:27:23 UTC) #5
jcgregorio
On 2014/09/30 13:27:23, tfarina wrote: > Ping? > > Remember that this is 'webtry' only. ...
6 years, 2 months ago (2014-09-30 15:00:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613593002/1
6 years, 2 months ago (2014-09-30 15:08:37 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 15:17:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as fffa16cc277c286687b0f42a7cc87217dd94938e

Powered by Google App Engine
This is Rietveld 408576698