src/IceRegistersX8632.h - Issue 613483002: Change some explicit type checks into using helper functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceRegistersX8632.h

Issue 613483002: Change some explicit type checks into using helper functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: rename Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceRegistersX8632.h

diff --git a/src/IceRegistersX8632.h b/src/IceRegistersX8632.h

index cbbcfc93044efe0b4b2f49a0756935f99a32da29..851908c3af7525b13764bcbdc845436cd761d4b7 100644

--- a/src/IceRegistersX8632.h

+++ b/src/IceRegistersX8632.h

@@ -85,7 +85,7 @@ static inline ByteRegister getEncodedByteReg(int32_t RegNum) {

}

static inline GPRRegister getEncodedByteRegOrGPR(Type Ty, int32_t RegNum) {

- if (Ty == IceType_i8 || Ty == IceType_i1)

+ if (isByteSizedType(Ty))

return GPRRegister(getEncodedByteReg(RegNum));

else

return getEncodedGPR(RegNum);

« no previous file with comments | « src/IceInstX8632.cpp ('k') | src/IceTargetLoweringX8632.cpp » ('j') | src/IceTargetLoweringX8632.cpp » ('J')