Issue 613473002: gn format: properly break and align multiple suffix comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 613473002: gn format: properly break and align multiple suffix comments (Closed)

Created:
6 years, 2 months ago by scottmg

Modified:
6 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-list-comment-spacing

Project:
chromium

Visibility:
Public.

gn format: properly break and align multiple suffix comments Previously a = [ "x", "y", # Comment1 # Comment2 ] would turn into a = [ "x", "y", # Comment1# Comment2 ] (Child of https://codereview.chromium.org/606123002/) R=brettw@chromium.org BUG=348474 Committed: https://chromium.googlesource.com/chromium/src/+/7461dcda6673ccd78b82efc4719e1389fc0c215b

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -1 line)			Patch
M	tools/gn/command_format.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	tools/gn/command_format_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/gn/format_test_data/020.gn	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	tools/gn/format_test_data/020.golden	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/7461dcda6673ccd78b82efc4719e1389fc0c215b Cr-Commit-Position: refs/heads/master@{#297235}

6 years, 2 months ago (2014-09-29 19:38:30 UTC) #3

scottmg

6 years, 2 months ago (2014-09-29 19:38:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7461dcda6673ccd78b82efc4719e1389fc0c215b (presubmit successful).