ui/events/gesture_detection/gesture_configuration_default.cc - Issue 613373004: Adopt ui::GestureConfiguration on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/gesture_detection/gesture_configuration_default.cc

Issue 613373004: Adopt ui::GestureConfiguration on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add dependencies Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/events/gesture_detection/gesture_configuration_aura.cc ('K') | « ui/events/gesture_detection/gesture_configuration_aura.cc ('k') | ui/events/gestures/gesture_configuration.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/events/gesture_detection/gesture_config_helper.h"	5 #include "ui/events/gesture_detection/gesture_configuration.h"

6	6

7 #include "ui/gfx/screen.h"	7 #include "ui/gfx/screen.h"

8	8

9 namespace ui {	9 namespace ui {

10	10

	11 GestureConfiguration* GestureConfiguration::GetInstance() {
	tdresser 2014/10/21 15:21:58 Why do we need a default which is different from b Why do we need a default which is different from both Android and Aura? jdduke (slow) 2014/10/21 16:02:06 This is used on Mac (devtools touch emulation). Show quoted text On 2014/10/21 15:21:58, tdresser wrote: > Why do we need a default which is different from both Android and Aura? This is used on Mac (devtools touch emulation). jdduke (slow) 2014/10/21 16:15:12 Absolutely. There's a TODO in touch_emulator.cc to Show quoted text On 2014/10/21 16:02:06, jdduke wrote: > On 2014/10/21 15:21:58, tdresser wrote: > > Why do we need a default which is different from both Android and Aura? > > This is used on Mac (devtools touch emulation). Absolutely. There's a TODO in touch_emulator.cc to do just that, but I went ahead and filed crbug.com/425586.
	12 return Singleton<GestureConfiguration>::get();

	13 }

	14

11 GestureProvider::Config DefaultGestureProviderConfig() {	15 GestureProvider::Config DefaultGestureProviderConfig() {

12 GestureProvider::Config config;	16 GestureProvider::Config config;

13 config.display = gfx::Screen::GetNativeScreen()->GetPrimaryDisplay();	17 config.display = gfx::Screen::GetNativeScreen()->GetPrimaryDisplay();

14 return config;	18 return config;

15 }	19 }

16	20

17 } // namespace ui	21 } // namespace ui

OLD	NEW