Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Issue 613333002: Fix type check in ssl interstitials (Closed)

Created:
6 years, 2 months ago by meacer
Modified:
6 years, 2 months ago
Reviewers:
felt
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-fix type check in ssl interstitials. BUG=418851 TBR=bauerb@chromium.org Committed: https://crrev.com/ee01cdb7afcaebbe2ea8167962a85e004c456f1a Cr-Commit-Position: refs/heads/master@{#297501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/security_warnings/ssl.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
meacer
This time with a nicer operator :) With the previous change SB interstitial tries to ...
6 years, 2 months ago (2014-09-30 19:40:13 UTC) #2
felt
On 2014/09/30 19:40:13, Mustafa Emre Acer wrote: > This time with a nicer operator :) ...
6 years, 2 months ago (2014-09-30 19:42:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613333002/1
6 years, 2 months ago (2014-09-30 19:45:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 463791b10cc0284a1de46cd1c4dead3371226d6c
6 years, 2 months ago (2014-09-30 21:25:21 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 21:26:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee01cdb7afcaebbe2ea8167962a85e004c456f1a
Cr-Commit-Position: refs/heads/master@{#297501}

Powered by Google App Engine
This is Rietveld 408576698