editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java - Issue 613303003: Rework EvaluationResultImpl class hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

Issue 613303003: Rework EvaluationResultImpl class hierarchy. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rework to use ErrorReporter Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java ('K') | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/element/ElementFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

index ea0a56f5a8d3c47d028c0726aa54e566911188c2..7089bb75a63fe3093113f2639357ddb4d01a2681 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

@@ -127,7 +127,6 @@ import com.google.dart.engine.error.ErrorProperty;

import com.google.dart.engine.error.StaticTypeWarningCode;

import com.google.dart.engine.error.StaticWarningCode;

import com.google.dart.engine.internal.constant.EvaluationResultImpl;

-import com.google.dart.engine.internal.constant.ValidResult;

import com.google.dart.engine.internal.element.FieldElementImpl;

import com.google.dart.engine.internal.element.FieldFormalParameterElementImpl;

import com.google.dart.engine.internal.element.LabelElementImpl;

@@ -6211,8 +6210,7 @@ public class ErrorVerifier extends RecursiveAstVisitor<Void> {

// }

private boolean isUserDefinedObject(EvaluationResultImpl result) {

- return result == null

- || (result instanceof ValidResult && ((ValidResult) result).isUserDefinedObject());

+ return result == null || (result.getValue() != null && result.getValue().isUserDefinedObject());

}

/**