editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/EnumMemberBuilder.java - Issue 613303003: Rework EvaluationResultImpl class hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/EnumMemberBuilder.java

Issue 613303003: Rework EvaluationResultImpl class hierarchy. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rework to use ErrorReporter Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/constant/ConstantEvaluator.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantValueComputer.java » ('j') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/EnumMemberBuilder.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/EnumMemberBuilder.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/EnumMemberBuilder.java

index 8219d9db9e1bd9c8de12fa343f08e7bbd2b6ded2..f40dcf6c73c7ba46f6ecf10259d4239346c5bf9c 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/EnumMemberBuilder.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/EnumMemberBuilder.java

@@ -20,7 +20,7 @@ import com.google.dart.engine.ast.SimpleIdentifier;

import com.google.dart.engine.ast.visitor.RecursiveAstVisitor;

import com.google.dart.engine.element.FieldElement;

import com.google.dart.engine.element.PropertyAccessorElement;

-import com.google.dart.engine.internal.constant.ValidResult;

+import com.google.dart.engine.internal.constant.EvaluationResultImpl;

import com.google.dart.engine.internal.element.ClassElementImpl;

import com.google.dart.engine.internal.element.ConstFieldElementImpl;

import com.google.dart.engine.internal.element.FieldElementImpl;

@@ -103,7 +103,7 @@ public class EnumMemberBuilder extends RecursiveAstVisitor<Void> {

HashMap<String, DartObjectImpl> fieldMap = new HashMap<String, DartObjectImpl>();

fieldMap.put(indexFieldName, new DartObjectImpl(intType, new IntState(BigInteger.valueOf(i))));

DartObjectImpl value = new DartObjectImpl(enumType, new GenericState(fieldMap));

- constantField.setEvaluationResult(new ValidResult(value));

+ constantField.setEvaluationResult(new EvaluationResultImpl(value));

fields.add(constantField);

getters.add(createGetter(constantField));

constantName.setStaticElement(constantField);