Source/core/rendering/RenderGrid.h - Issue 613273002: [CSS Grid Layout] Stretch value for align and justify properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.h

Issue 613273002: [CSS Grid Layout] Stretch value for align and justify properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: resolveAlignment and resolveJustification now defined in RenderStyle. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-align.html ('K') | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderGrid.h

diff --git a/Source/core/rendering/RenderGrid.h b/Source/core/rendering/RenderGrid.h

index 4136230e84db00cb6960b63b28f82db56fa410a6..cddb42315649507a9b19fc1e78c205724edb1647 100644

--- a/Source/core/rendering/RenderGrid.h

+++ b/Source/core/rendering/RenderGrid.h

@@ -128,6 +128,13 @@ private:

LayoutUnit gridAreaBreadthForChild(const RenderBox& child, GridTrackSizingDirection, const Vector<GridTrack>&) const;

virtual void paintChildren(PaintInfo&, const LayoutPoint&) override;

+ bool needToStretchChildLogicalHeight(const RenderBox&) const;

+ LayoutUnit childIntrinsicHeight(const RenderBox&) const;

+ LayoutUnit childIntrinsicWidth(const RenderBox&) const;

+ LayoutUnit intrinsicLogicalHeightForChild(const RenderBox&) const;

+ LayoutUnit marginLogicalHeightForChild(const RenderBox&) const;

+ LayoutUnit availableAlignmentSpaceForChildBeforeStretching(LayoutUnit gridAreaBreadthForChild, const RenderBox&) const;

+ void applyStretchAlignmentToChildIfNeeded(RenderBox&, LayoutUnit gridAreaBreadthForChild);

#if ENABLE(ASSERT)

bool tracksAreWiderThanMinTrackBreadth(GridTrackSizingDirection, const Vector<GridTrack>&);