Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 613243002: Ownership of UMA things. (Closed)

Created:
6 years, 2 months ago by MAD
Modified:
6 years, 2 months ago
Reviewers:
csharp, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ownership of UMA things. BUG=None Committed: https://crrev.com/03458b20526123ce30afc6dabd96d0250294d6b1 Cr-Commit-Position: refs/heads/master@{#297486}

Patch Set 1 #

Total comments: 3

Patch Set 2 : CR Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tools/metrics/actions/actions.xml View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
MAD
6 years, 2 months ago (2014-09-30 14:59:08 UTC) #2
csharp
https://codereview.chromium.org/613243002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/613243002/diff/1/tools/metrics/histograms/histograms.xml#newcode29774 tools/metrics/histograms/histograms.xml:29774: + <owner>csharp@chromium.org</owner> I don't think I should be the ...
6 years, 2 months ago (2014-09-30 15:06:16 UTC) #3
MAD
Thanks... https://codereview.chromium.org/613243002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/613243002/diff/1/tools/metrics/histograms/histograms.xml#newcode29774 tools/metrics/histograms/histograms.xml:29774: + <owner>csharp@chromium.org</owner> On 2014/09/30 15:06:16, csharp wrote: > ...
6 years, 2 months ago (2014-09-30 15:18:09 UTC) #4
csharp
lgtm https://codereview.chromium.org/613243002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/613243002/diff/1/tools/metrics/histograms/histograms.xml#newcode29774 tools/metrics/histograms/histograms.xml:29774: + <owner>csharp@chromium.org</owner> On 2014/09/30 15:18:09, MAD wrote: > ...
6 years, 2 months ago (2014-09-30 15:20:38 UTC) #5
MAD
OWNER review please... Thanks! BYE MAD
6 years, 2 months ago (2014-09-30 15:24:25 UTC) #7
jwd
lgtm
6 years, 2 months ago (2014-09-30 17:02:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613243002/20001
6 years, 2 months ago (2014-09-30 17:56:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4ee8ce2d4293da50aac143471e8becffd70e7c1d
6 years, 2 months ago (2014-09-30 20:01:56 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 20:02:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03458b20526123ce30afc6dabd96d0250294d6b1
Cr-Commit-Position: refs/heads/master@{#297486}

Powered by Google App Engine
This is Rietveld 408576698