Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 613233002: [NaCl SDK] Update naclports revision used to build gonacl.com examples (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Update naclports revision used to build gonacl.com examples This fixed the build of lua and bullet which was broken by the recent change in PNaCl toolchain layout. Committed: https://crrev.com/6dd982c12a7845366d0e108612a452e50e1bd5da Cr-Commit-Position: refs/heads/master@{#297436}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -23 lines) Patch
M native_client_sdk/src/gonacl_appengine/src/bullet/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/bullet/build.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/lua/build.sh View 1 2 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
6 years, 2 months ago (2014-09-30 14:42:10 UTC) #2
binji
lgtm
6 years, 2 months ago (2014-09-30 14:54:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613233002/20001
6 years, 2 months ago (2014-09-30 16:11:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0b8a840bcfe851083835845a69e127e3882b38e8
6 years, 2 months ago (2014-09-30 16:46:21 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 16:47:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dd982c12a7845366d0e108612a452e50e1bd5da
Cr-Commit-Position: refs/heads/master@{#297436}

Powered by Google App Engine
This is Rietveld 408576698