Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4076)

Unified Diff: chrome/browser/profiles/profile_io_data.cc

Issue 61323002: Fix broken threading model in CheckDesktopNotificationPermission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_io_data.cc
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index f973d9fa71427b0740c6bff1dd2a50276321cb28..9ef299828d19415b82aa3b6ee35bf27722f901cf 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -46,7 +46,6 @@
#include "chrome/browser/net/proxy_service_factory.h"
#include "chrome/browser/net/resource_prefetch_predictor_observer.h"
#include "chrome/browser/net/transport_security_persister.h"
-#include "chrome/browser/notifications/desktop_notification_service_factory.h"
#include "chrome/browser/policy/url_blacklist_manager.h"
#include "chrome/browser/predictors/resource_prefetch_predictor.h"
#include "chrome/browser/predictors/resource_prefetch_predictor_factory.h"
@@ -272,11 +271,6 @@ void ProfileIOData::InitializeOnUIThread(Profile* profile) {
new chrome_browser_net::ResourcePrefetchPredictorObserver(predictor));
}
-#if defined(ENABLE_NOTIFICATIONS)
- params->notification_service =
- DesktopNotificationServiceFactory::GetForProfile(profile);
-#endif
-
ProtocolHandlerRegistry* protocol_handler_registry =
ProtocolHandlerRegistryFactory::GetForProfile(profile);
DCHECK(protocol_handler_registry);
@@ -405,9 +399,6 @@ ProfileIOData::AppRequestContext::~AppRequestContext() {}
ProfileIOData::ProfileParams::ProfileParams()
: io_thread(NULL),
-#if defined(ENABLE_NOTIFICATIONS)
- notification_service(NULL),
-#endif
profile(NULL) {
}
@@ -415,9 +406,6 @@ ProfileIOData::ProfileParams::~ProfileParams() {}
ProfileIOData::ProfileIOData(bool is_incognito)
: initialized_(false),
-#if defined(ENABLE_NOTIFICATIONS)
- notification_service_(NULL),
-#endif
resource_context_(new ResourceContext(this)),
load_time_stats_(NULL),
initialized_on_UI_thread_(false),
@@ -638,13 +626,6 @@ HostContentSettingsMap* ProfileIOData::GetHostContentSettingsMap() const {
return host_content_settings_map_.get();
}
-#if defined(ENABLE_NOTIFICATIONS)
-DesktopNotificationService* ProfileIOData::GetNotificationService() const {
- DCHECK(initialized_);
- return notification_service_;
-}
-#endif
-
void ProfileIOData::InitializeMetricsEnabledStateOnUIThread() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
#if defined(OS_CHROMEOS)
@@ -822,9 +803,6 @@ void ProfileIOData::Init(content::ProtocolHandlerMap* protocol_handlers) const {
// Take ownership over these parameters.
cookie_settings_ = profile_params_->cookie_settings;
host_content_settings_map_ = profile_params_->host_content_settings_map;
-#if defined(ENABLE_NOTIFICATIONS)
- notification_service_ = profile_params_->notification_service;
-#endif
extension_info_map_ = profile_params_->extension_info_map;
resource_context_->host_resolver_ = io_thread_globals->host_resolver.get();
« chrome/browser/extensions/extension_info_map.h ('K') | « chrome/browser/profiles/profile_io_data.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698