chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py - Issue 613223003: Fix ChromeVox Next compile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

Issue 613223003: Fix ChromeVox Next compile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Fix commit presubmit. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/externs.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

diff --git a/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py b/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

index d2b3f9abda7dfdbae758145303bb1c14bd06f5a0..41f3d4c690e07b59a14c6fab7cb045d2ca86d63a 100755

--- a/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

+++ b/chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py

@@ -36,6 +36,7 @@ def CVoxPath(path='.'):

# Externs common to many ChromeVox scripts.

_COMMON_EXTERNS = [

+ CVoxPath('cvox2/background/externs.js'),

Peter Lundblad 2014/10/01 08:55:07 I dont' think we need to add this to chromevox cla

David Tseng 2014/10/01 16:18:13 Deleting in subsequent cl.

CVoxPath('common/externs.js'),

CVoxPath('common/chrome_extension_externs.js'),

CVoxPath('chromevox/background/externs.js'),

@@ -50,6 +51,7 @@ _TOP_LEVEL_SCRIPTS = [

[[CVoxPath('chromevox/background/loader.js')], _COMMON_EXTERNS],

[[CVoxPath('chromevox/background/options_loader.js')], _COMMON_EXTERNS],

[[CVoxPath('chromevox/injected/loader.js')], _COMMON_EXTERNS],

+ [[CVoxPath('cvox2/background/loader.js')], _COMMON_EXTERNS],

]