Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 613213002: [Patch resubmit]: Turn off autofill highlight when changing option in an autofilled <select> element (Closed)

Created:
6 years, 2 months ago by ziran.sun
Modified:
6 years, 2 months ago
Reviewers:
tkent, Mike West
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Patch resubmit]: Turn off autofill highlight when changing option in an autofilled <select> element ------------------------------------------------------------ This is a re-land of https://codereview.chromium.org/553983012/, which was reverted as it broke FormAutofillTest.ClearFormWithNodeContainingSelectOne browser_test. The browser_test has now been updated in chromium. ------------------------------------------------------------ R=tkent@chromium.org BUG=412311 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183127

Patch Set 1 #

Patch Set 2 : Remove platform specific expectation files. #

Total comments: 1

Patch Set 3 : Update code as per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -116 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/autofilled.html View 6 chunks +15 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/autofilled-expected.txt View 3 chunks +5 lines, -1 line 0 comments Download
D LayoutTests/platform/linux/fast/forms/autofilled-expected.txt View 1 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/forms/autofilled-expected.txt View 1 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/win/fast/forms/autofilled-expected.txt View 1 1 chunk +0 lines, -38 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ziran.sun
Please review. Thanks!
6 years, 2 months ago (2014-10-01 10:03:56 UTC) #1
Mike West
LGTM. For clarity, please link to the original patch in the change description (similar to ...
6 years, 2 months ago (2014-10-01 10:10:33 UTC) #3
tkent
lgtm https://codereview.chromium.org/613213002/diff/20001/Source/core/html/HTMLSelectElement.cpp File Source/core/html/HTMLSelectElement.cpp (right): https://codereview.chromium.org/613213002/diff/20001/Source/core/html/HTMLSelectElement.cpp#newcode931 Source/core/html/HTMLSelectElement.cpp:931: if (selectedIndex() != optionIndex && this->isAutofilled()) |this->| is ...
6 years, 2 months ago (2014-10-01 23:31:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613213002/40001
6 years, 2 months ago (2014-10-02 09:12:50 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 10:15:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183127

Powered by Google App Engine
This is Rietveld 408576698