content/renderer/device_sensors/device_sensor_event_pump.h - Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/device_sensors/device_sensor_event_pump.h

Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up a comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/battery_status/battery_status_dispatcher.cc ('k') | content/renderer/gamepad_shared_memory_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/device_sensors/device_sensor_event_pump.h

diff --git a/content/renderer/device_sensors/device_sensor_event_pump.h b/content/renderer/device_sensors/device_sensor_event_pump.h

index c77db34c42a15d2f0c8426a3979cf9e86d420d2e..e109c113ed24c0a7b185183f98153d3bdb7131b3 100644

--- a/content/renderer/device_sensors/device_sensor_event_pump.h

+++ b/content/renderer/device_sensors/device_sensor_event_pump.h

@@ -56,6 +56,7 @@ class CONTENT_EXPORT DeviceSensorEventPump

state_(STOPPED) {}

virtual ~DeviceSensorEventPump() {

+ PlatformEventObserver<ListenerType>::StopIfObserving();

}

// The pump is a tri-state automaton with allowed transitions as follows:

« no previous file with comments | « content/renderer/battery_status/battery_status_dispatcher.cc ('k') | content/renderer/gamepad_shared_memory_reader.cc » ('j') | no next file with comments »