content/renderer/gamepad_shared_memory_reader.cc - Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gamepad_shared_memory_reader.cc

Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/platform_event_observer.h ('K') | « content/renderer/device_sensors/device_sensor_event_pump.h ('k') | content/renderer/screen_orientation/screen_orientation_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/gamepad_shared_memory_reader.cc

diff --git a/content/renderer/gamepad_shared_memory_reader.cc b/content/renderer/gamepad_shared_memory_reader.cc

index 5f8d31aa5705d988c76c1535da6acfaf26bad1d3..7040a9b6eeda60a92dea161fd1b91d281095baeb 100644

--- a/content/renderer/gamepad_shared_memory_reader.cc

+++ b/content/renderer/gamepad_shared_memory_reader.cc

@@ -105,6 +105,7 @@ void GamepadSharedMemoryReader::SampleGamepads(blink::WebGamepads& gamepads) {

}

GamepadSharedMemoryReader::~GamepadSharedMemoryReader() {

+ StopIfObserving();

}

bool GamepadSharedMemoryReader::OnControlMessageReceived(