LayoutTests/fast/text/emphasis-ellipsis-complextext.html - Issue 613193002: Avoid drawing emphasis marks over ellipsis glyphs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/text/emphasis-ellipsis-complextext.html

Issue 613193002: Avoid drawing emphasis marks over ellipsis glyphs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added antialiased test in TestExpectations Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/platform/linux/fast/text/emphasis-ellipsis-complextext-expected.png » ('j') | Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE>

	2 <meta charset='utf-8'>

	3 <title>Emphasis Mark on Complex Text with Ellipsis</title>

	4 <style>

	5 div {

	6 -webkit-text-emphasis: dot;

	7 font-size: 36pt;

	8 width: 220px;

	9 white-space: nowrap;

	10 overflow: hidden;

	11 text-overflow: ellipsis;

	12 direction: rtl;

	13 }

	14 </style>

	15 <body>

	16 <p>There should be no dots above the ellipsis.</p>

	17 <div>هذا هو الاختبار</div>

	18 <div>abcd efg hijk<div>
	Dominik Röttsches 2014/09/30 12:27:00 Could you add a line with dir=rtl and latin text? Could you add a line with dir=rtl and latin text? Habib Virji 2014/09/30 13:28:40 You mean something like this right? <div dir="rtl" Show quoted text On 2014/09/30 12:27:00, Dominik Röttsches wrote: > Could you add a line with dir=rtl and latin text? You mean something like this right? <div dir="rtl">abcd efg hijk<div> <div dir="rtl">كتاب ألف ليلة وليلة</div> <div>Af̀fiZ Default Font</div> Dominik Röttsches 2014/09/30 13:48:23 Yes. Show quoted text On 2014/09/30 13:28:40, Habib Virji wrote: > On 2014/09/30 12:27:00, Dominik Röttsches wrote: > > Could you add a line with dir=rtl and latin text? > > You mean something like this right? > <div dir="rtl">abcd efg hijk<div> Yes. Show quoted text > <div dir="rtl">كتاب ألف ليلة وليلة</div> Arabic should be RTL by default in this case, so no need to add the direction here. <div>Af̀fiZ Default Font</div> We're not testing for ligatures here, so this line wouldn't be needed.
	19 <div>كتاب ألف ليلة وليلة</div>

	20 </body>

OLD	NEW