Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 613173004: Move notifications to after the process has indeed closed. (Closed)

Created:
6 years, 2 months ago by nasko
Modified:
6 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move notifications to after the process has indeed closed. Renderer process closed notification implies that the process is already gone. In reality, this is not always the case since calling ProcessDied(false) is supposed to tear down the process. It however sends the notification before doing so. This patch moves the notifications to after the process is closed and the IPC channel is torn down. BUG= Committed: https://crrev.com/165a7f28c672a899924051df4b29682756d51858 Cr-Commit-Position: refs/heads/master@{#297698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nasko
Hey John, Can you review this CL for me? It passed all green and we ...
6 years, 2 months ago (2014-10-01 17:43:25 UTC) #2
jam
lgtm
6 years, 2 months ago (2014-10-01 19:38:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613173004/1
6 years, 2 months ago (2014-10-01 19:55:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7119a9d5b02d29a6726dcd292a28da826a40df4b
6 years, 2 months ago (2014-10-01 20:00:47 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 20:01:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/165a7f28c672a899924051df4b29682756d51858
Cr-Commit-Position: refs/heads/master@{#297698}

Powered by Google App Engine
This is Rietveld 408576698