Made SuspendableTimer smaller (removed redudant m_active field)

Source/core/frame/SuspendableTimer.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 15 matching lines @@
 
 #include "config.h"
 #include "core/frame/SuspendableTimer.h"
 
 namespace blink {
 
 SuspendableTimer::SuspendableTimer(ExecutionContext* context)
     : ActiveDOMObject(context)
     , m_nextFireInterval(0)
     , m_repeatInterval(0)
-    , m_active(false)
 #if ENABLE(ASSERT)
     , m_suspended(false)
 #endif
 {
 }
 
 SuspendableTimer::~SuspendableTimer()
 {
 }
 
 bool SuspendableTimer::hasPendingActivity() const
 {
     return isActive();
 }
 
 void SuspendableTimer::stop()
 {
+    m_nextFireInterval = 0;
     TimerBase::stop();
 }
 
 void SuspendableTimer::suspend()
 {
 #if ENABLE(ASSERT)
     ASSERT(!m_suspended);
     m_suspended = true;
 #endif
-    m_active = isActive();
-    if (m_active) {
+    if (isActive()) {
         m_nextFireInterval = nextUnalignedFireInterval();
         m_repeatInterval = repeatInterval();
         TimerBase::stop();
     }
 }
 
 void SuspendableTimer::resume()
 {
 #if ENABLE(ASSERT)
     ASSERT(m_suspended);
     m_suspended = false;
 #endif
-    // FIXME: FROM_HERE is wrong here.
-    if (m_active)
-        start(m_nextFireInterval, m_repeatInterval, FROM_HERE);
+    if (m_nextFireInterval) {
+        // start() was called before, therefore location() is already set.

[Mike West, 2014/10/04 16:58:49]

Hrm. It looks like it's safe to use m_nextFireInterval as an isActive proxy
here; it's only set in ::suspend, and only if the timer was active. Can you add
something to the comment here to that effect?

+        start(m_nextFireInterval, m_repeatInterval, location());
+        m_nextFireInterval = 0;
+    }
 }
 
 } // namespace blink