Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 613163004: [chromedriver] setting browser default download directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modified codes based on reviewer's comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index 14d596ea54556e59d693474a7718a9ef8edd5d0b..954486db1ee803abffd99c29befcb647b989317b 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -86,8 +86,14 @@ ChromeDesktopImpl::~ChromeDesktopImpl() {
if (!quit_) {
base::FilePath user_data_dir = user_data_dir_.Take();
base::FilePath extension_dir = extension_dir_.Take();
- LOG(WARNING) << "chrome detaches, user should take care of directory:"
- << user_data_dir.value() << " and " << extension_dir.value();
+ //
samuong 2014/10/17 21:52:25 can you please make sure to delete these comments?
andrewcheng 2014/10/17 22:59:56 Done.
+ LOG(WARNING) << "chrome quit unexpectedly, leaving behind temporary "
+ "directories for debugging:";
+ if (user_data_dir_.IsValid())
+ LOG(WARNING) << "chrome user data directory: " << user_data_dir.value();
+ if (extension_dir_.IsValid())
+ LOG(WARNING) << "chromedriver automation extension directory: "
+ << extension_dir.value();
}
base::CloseProcessHandle(process_);
}
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome_launcher.cc » ('j') | chrome/test/chromedriver/chrome_launcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698