[chromedriver] setting browser default download directory

chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index 14d596ea54556e59d693474a7718a9ef8edd5d0b..19e6202c4a14df32d0fb5992e5bc381130a63217 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -86,8 +86,11 @@ ChromeDesktopImpl::~ChromeDesktopImpl() {
   if (!quit_) {
     base::FilePath user_data_dir = user_data_dir_.Take();
     base::FilePath extension_dir = extension_dir_.Take();
-    LOG(WARNING) << "chrome detaches, user should take care of directory:"
-                 << user_data_dir.value() << " and " << extension_dir.value();
+    LOG(WARNING) << "chrome detaches, user should take care of "
+      "following directory:";
+    if (user_data_dir_.IsValid())
+      LOG(WARNING) <<  user_data_dir.value();
+    LOG(WARNING) << " and " << extension_dir.value();

[samuong, 2014/10/16 20:23:40]

This error message is awkwardly worded. If the user data dir is not valid, it
will say "and" even though it only prints out one directory. How about we change
it to:

LOG(WARNING) << "chrome quit unexpectedly, leaving behind temporary directories
for debugging:";
if (user_data_dir_.IsValid())
  LOG(WARNING) << "chrome user data directory: " << user_data_dir.value();
if (extension_dir.IsValid())
  LOG(WARNING) << "chromedriver automation extension directory: " <<
extension_dir.value();

   }
   base::CloseProcessHandle(process_);
 }