Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8706)

Unified Diff: chrome/test/chromedriver/client/chromedriver.py

Issue 613163004: [chromedriver] setting browser default download directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test testDownloadDirectoryOverridesExistingPreferences Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/client/chromedriver.py
diff --git a/chrome/test/chromedriver/client/chromedriver.py b/chrome/test/chromedriver/client/chromedriver.py
index fb1aa2b27fded702a22419ca0273bc43a79de2d2..04de4f7871d4b52194eb9390981d89e1ffa7e77e 100644
--- a/chrome/test/chromedriver/client/chromedriver.py
+++ b/chrome/test/chromedriver/client/chromedriver.py
@@ -60,7 +60,8 @@ def _ExceptionForResponse(response):
class ChromeDriver(object):
"""Starts and controls a single Chrome instance on this machine."""
- def __init__(self, server_url, chrome_binary=None, android_package=None,
+ def __init__(self, server_url, download_dir=None, chrome_binary=None,
+ android_package=None,
android_activity=None, android_process=None,
android_use_running_app=None, chrome_switches=None,
chrome_extensions=None, chrome_log_path=None,
@@ -115,6 +116,17 @@ class ChromeDriver(object):
assert performance_log_level in log_levels
logging_prefs['performance'] = performance_log_level
+ download_prefs = {}
+ if (download_dir):
+ #options['directory_upgrade'] = 'true'
+ #options['default_directory'] = download_dir
+ #
samuong 2014/10/15 22:08:17 Can we get rid of these kinds of comments? As I me
+ default_dir = {}
+ default_dir['directory_upgrade'] = 'true'
+ default_dir['default_directory'] = download_dir
+ download_prefs['download'] = default_dir
+ options['prefs'] = download_prefs
+
params = {
'desiredCapabilities': {
'chromeOptions': options,

Powered by Google App Engine
This is Rietveld 408576698