[chromedriver] setting browser default download directory

chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index 14d596ea54556e59d693474a7718a9ef8edd5d0b..80bbe57bb4247b7280bf0c3bcc0fcb391b764ec1 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -76,8 +76,9 @@ ChromeDesktopImpl::ChromeDesktopImpl(
                  port_reservation.Pass()),
       process_(process),
       command_(command) {
-  if (user_data_dir->IsValid())
-    CHECK(user_data_dir_.Set(user_data_dir->Take()));
+  if (user_data_dir->IsValid()) {
+      CHECK(user_data_dir_.Set(user_data_dir->Take()));
+  }

[samuong, 2014/10/15 22:08:17]

Since you're not changing anything here, please delete the braces and restore
the indenting. That way, the version history will stay clean and tools like
git-blame will be more useful.

   if (extension_dir->IsValid())
     CHECK(extension_dir_.Set(extension_dir->Take()));
 }
@@ -86,8 +87,11 @@ ChromeDesktopImpl::~ChromeDesktopImpl() {
   if (!quit_) {
     base::FilePath user_data_dir = user_data_dir_.Take();
     base::FilePath extension_dir = extension_dir_.Take();
-    LOG(WARNING) << "chrome detaches, user should take care of directory:"
-                 << user_data_dir.value() << " and " << extension_dir.value();
+    LOG(WARNING) << "chrome detaches, user should take care of "
+        "following directory:";
+    if (user_data_dir_.IsValid())
+        LOG(WARNING) <<  user_data_dir.value();
+    LOG(WARNING) << " and " << extension_dir.value();
   }
   base::CloseProcessHandle(process_);
 }