Credential Manager: Return the first valid item from the PasswordStore.

Credential Manager: Return the first valid item from the PasswordStore.

This patch completes the initial, dead simple, pretty dumb implementation
of '.request()'. We poke at the PasswordStore for the origin currently
committed in the RenderViewHost's main frame, and if we get anything at
all, we return it.

We can't expose this implementation to the web for obvious reasons. But
it's pefectly wonderful for testing.

BUG=400674
Committed: https://crrev.com/e4c5d27cdb953539094774f7b6c57637a2bba4e1
Cr-Commit-Position: refs/heads/master@{#297598}

[Mike West, 2014-09-30 11:26:48]

mkwst@chromium.org changed reviewers:
+ vabr@chromium.org

[Mike West, 2014-09-30 11:26:48]

One more, Vaclav. Mind taking a look? It depends on the other two patches you
reviewed today, so I can't throw it to the bots quite yet.

-mike

[vabr (Chromium), 2014-09-30 12:16:55]

LGTM!
Vaclav

https://codereview.chromium.org/613143003/diff/1/components/password_manager/...
File
components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
(right):

https://codereview.chromium.org/613143003/diff/1/components/password_manager/...
components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc:135:
RunAllPendingTasks();
There are multiple copies of the same sink-checking code across the tests.
Please consider making it a helper method taking the message type ID and
returning IPC::Message.

https://codereview.chromium.org/613143003/diff/1/components/password_manager/...
File components/password_manager/content/common/credential_manager_types.h
(right):

https://codereview.chromium.org/613143003/diff/1/components/password_manager/...
components/password_manager/content/common/credential_manager_types.h:37:
CredentialInfo(const autofill::PasswordForm& form);
[No action required] Just out of curiosity, do you expect to use all three
constructors in the future, or is this exploratory, and likely to stick with 1
or 2?

[Mike West, 2014-10-01 04:47:38]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-10-01 04:48:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/613143003/1

[commit-bot: I haz the power, 2014-10-01 05:43:52]

Committed patchset #1 (id:1) as d1d8a680ef7a9d59aaa2e557ebc2e3e410f9dc86

[commit-bot: I haz the power, 2014-10-01 05:44:34]

Patchset 1 (id:??) landed as
https://crrev.com/e4c5d27cdb953539094774f7b6c57637a2bba4e1
Cr-Commit-Position: refs/heads/master@{#297598}

[tapted, 2014-10-01 07:00:41]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/619033002/ by tapted@chromium.org.

The reason for reverting is: Tests
CredentialManagerOnRequestCredentialWhileRequestPending, 
CredentialManagerOnRequestCredentialWithFullPasswordStore
failing on Linux ASan LSan Tests (1)
link:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

errors like:
Direct leak of 1056 byte(s) in 1 object(s) allocated from:
    #0 0x52e7cb in operator new(unsigned long)
(/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/components_unittests+0x52e7cb)
    #1 0x21e965f in
password_manager::TestPasswordStore::GetLoginsImpl(autofill::PasswordForm
const&, password_manager::PasswordStore::AuthorizationPromptPolicy,
base::Callback\u003Cvoid (std::__1::vector\u003Cautofill::PasswordForm*,
std::__1::allocator\u003Cautofill::PasswordForm*> > const&)> const&)
components/password_manager/core/browser/test_password_store.cc:103:5
.