Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 613083003: gn format: support absolute file system paths (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn format: support absolute file system paths And update help text. R=brettw@chromium.org BUG=348474 Committed: https://crrev.com/ee0152bda8e2a11b83f996df3f0601fe4187eab5 Cr-Commit-Position: refs/heads/master@{#297926}

Patch Set 1 #

Patch Set 2 : help #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -19 lines) Patch
M tools/gn/command_format.cc View 1 4 chunks +31 lines, -17 lines 2 comments Download
M tools/gn/command_format_unittest.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M tools/gn/source_file.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scottmg
6 years, 2 months ago (2014-10-02 21:51:31 UTC) #1
scottmg
https://codereview.chromium.org/613083003/diff/20001/tools/gn/command_format.cc File tools/gn/command_format.cc (right): https://codereview.chromium.org/613083003/diff/20001/tools/gn/command_format.cc#newcode555 tools/gn/command_format.cc:555: CHECK(!in_place) << "TODO(scottmg)"; (is there an easy way to ...
6 years, 2 months ago (2014-10-02 21:54:29 UTC) #2
brettw
lgtm https://codereview.chromium.org/613083003/diff/20001/tools/gn/command_format.cc File tools/gn/command_format.cc (right): https://codereview.chromium.org/613083003/diff/20001/tools/gn/command_format.cc#newcode555 tools/gn/command_format.cc:555: CHECK(!in_place) << "TODO(scottmg)"; On 2014/10/02 21:54:29, scottmg wrote: ...
6 years, 2 months ago (2014-10-02 22:03:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613083003/20001
6 years, 2 months ago (2014-10-02 22:05:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 71fba890ec3a6125a72305ce078ba0cafac73d65
6 years, 2 months ago (2014-10-02 22:32:03 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 22:32:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee0152bda8e2a11b83f996df3f0601fe4187eab5
Cr-Commit-Position: refs/heads/master@{#297926}

Powered by Google App Engine
This is Rietveld 408576698