tools/dom/templates/html/impl/impl_Node.darttemplate - Issue 613063002: Make Node.nodes.insertAll take an end-positioned index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_Node.darttemplate

Issue 613063002: Make Node.nodes.insertAll take an end-positioned index. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/templates/html/impl/impl_Node.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_Node.darttemplate b/tools/dom/templates/html/impl/impl_Node.darttemplate

index 85f7e12c5833362c4d1c2c469124437cd16be284..830714911d3c7cd90aa1f49e69c050f15c38188b 100644

--- a/tools/dom/templates/html/impl/impl_Node.darttemplate

+++ b/tools/dom/templates/html/impl/impl_Node.darttemplate

@@ -83,8 +83,12 @@ $endif

}

void insertAll(int index, Iterable<Node> iterable) {

- var item = this[index];

- _this.insertAllBefore(iterable, item);

+ if (index == length) {

+ addAll(iterable);

+ } else {

+ var item = this[index];

+ _this.insertAllBefore(iterable, item);

+ }

}

void setAll(int index, Iterable<Node> iterable) {

« no previous file with comments | « tests/html/node_test.dart ('k') | no next file » | no next file with comments »