Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 613053002: Mojo: NULL -> nullptr in mojo/public/cpp/bindings and also for the bindings generator. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: NULL -> nullptr in mojo/public/cpp/bindings and also for the bindings generator. R=jamesr@chromium.org Committed: https://crrev.com/971cb69e6c9e425f3deca7575de710fff36d26ca Cr-Commit-Position: refs/heads/master@{#297336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M mojo/public/cpp/bindings/interface_ptr.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_serialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/filter_chain.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/filter_chain.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/fixed_buffer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_impl_internal.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message_header_validator.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/shared_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/string_serialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/no_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/struct_ptr.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/buffer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/router_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/string_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/type_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/validation_test_input_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_request_validator_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_response_validator_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-09-30 00:52:50 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-09-30 01:00:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613053002/1
6 years, 2 months ago (2014-09-30 01:02:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1053841dd617bc7d2d674de254f22c9bf22945b9
6 years, 2 months ago (2014-09-30 01:52:09 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 01:53:05 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/971cb69e6c9e425f3deca7575de710fff36d26ca
Cr-Commit-Position: refs/heads/master@{#297336}

Powered by Google App Engine
This is Rietveld 408576698