Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 613043005: OOPIF: Check whether localFrameRootTemporary is valid when processing resizing messages (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 83a3349f09e1dd989f3acd08a834a5fffb1524c4..69556273365d98db98f33b4329d0401f2c7cee01 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -1712,7 +1712,11 @@ void WebViewImpl::setTopControlsLayoutHeight(float height)
void WebViewImpl::didUpdateTopControls()
{
- FrameView* view = localFrameRootTemporary()->frameView();
+ WebLocalFrameImpl* localFrameRoot = localFrameRootTemporary();
+ if (!localFrameRoot)
+ return;
+
+ FrameView* view = localFrameRoot->frameView();
if (!view)
return;
@@ -1728,7 +1732,11 @@ void WebViewImpl::resize(const WebSize& newSize)
if (m_shouldAutoResize || m_size == newSize)
return;
- FrameView* view = localFrameRootTemporary()->frameView();
+ WebLocalFrameImpl* localFrameRoot = localFrameRootTemporary();
+ if (!localFrameRoot)
+ return;
+
+ FrameView* view = localFrameRoot->frameView();
if (!view)
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698