 Chromium Code Reviews
 Chromium Code Reviews Issue 613043002:
  Switching to C++11 range-based for loops  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 613043002:
  Switching to C++11 range-based for loops  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: components/copresence/rpc/rpc_handler_unittest.cc | 
| diff --git a/components/copresence/rpc/rpc_handler_unittest.cc b/components/copresence/rpc/rpc_handler_unittest.cc | 
| index 2bba24440312255b02b0263ebec0c96f451bbc69..2b2e61f267f7d367cbe179a2ea28ec7687455db7 100644 | 
| --- a/components/copresence/rpc/rpc_handler_unittest.cc | 
| +++ b/components/copresence/rpc/rpc_handler_unittest.cc | 
| @@ -31,11 +31,8 @@ void CreateSubscribedMessage(const std::vector<std::string>& subscription_ids, | 
| const std::string& message_string, | 
| SubscribedMessage* message_proto) { | 
| message_proto->mutable_published_message()->set_payload(message_string); | 
| - for (std::vector<std::string>::const_iterator subscription_id = | 
| - subscription_ids.begin(); | 
| - subscription_id != subscription_ids.end(); | 
| - ++subscription_id) { | 
| - message_proto->add_subscription_id(*subscription_id); | 
| + for (const std::string& subscription_id :subscription_ids) { | 
| 
rkc
2014/10/01 03:48:32
space after :
 
Charlie
2014/10/06 19:09:56
Done.
 | 
| + message_proto->add_subscription_id(subscription_id); | 
| } | 
| } | 
| @@ -214,7 +211,7 @@ TEST_F(RpcHandlerTest, ReportTokens) { | 
| rpc_handler_.ReportTokens(test_tokens); | 
| EXPECT_EQ(RpcHandler::kReportRequestRpcName, rpc_name_); | 
| ReportRequest* report = static_cast<ReportRequest*>(request_proto_.get()); | 
| - google::protobuf::RepeatedPtrField<TokenObservation> tokens_sent = | 
| + RepeatedPtrField<TokenObservation> tokens_sent = | 
| report->update_signals_request().token_observation(); | 
| ASSERT_EQ(2, tokens_sent.size()); | 
| EXPECT_EQ("token 1", tokens_sent.Get(0).token_id()); |