Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 613043002: Switching to C++11 range-based for loops (Closed)

Created:
6 years, 2 months ago by Charlie
Modified:
6 years, 2 months ago
Reviewers:
rkc, xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switching to C++11 range-based for loops Committed: https://crrev.com/853575ecd83de97fd334149a15b8fa399ef263a5 Cr-Commit-Position: refs/heads/master@{#298633}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -61 lines) Patch
M components/copresence/copresence_manager_impl.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 1 6 chunks +37 lines, -46 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M components/copresence/timed_map.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Charlie
These are now allowed: http://chromium-cpp.appspot.com/
6 years, 2 months ago (2014-09-30 00:52:31 UTC) #2
Charlie
6 years, 2 months ago (2014-09-30 19:45:51 UTC) #4
xiyuan
lgtm
6 years, 2 months ago (2014-09-30 19:54:30 UTC) #5
rkc
On 2014/09/30 19:54:30, xiyuan wrote: > lgtm Still looking at this.
6 years, 2 months ago (2014-09-30 19:55:13 UTC) #6
rkc
lgtm % comments https://codereview.chromium.org/613043002/diff/1/components/copresence/rpc/rpc_handler.cc File components/copresence/rpc/rpc_handler.cc (right): https://codereview.chromium.org/613043002/diff/1/components/copresence/rpc/rpc_handler.cc#newcode411 components/copresence/rpc/rpc_handler.cc:411: for (const std::pair<std::string, std::vector<Message>>& map_entry : ...
6 years, 2 months ago (2014-10-01 03:48:32 UTC) #7
Charlie
https://codereview.chromium.org/613043002/diff/1/components/copresence/rpc/rpc_handler.cc File components/copresence/rpc/rpc_handler.cc (right): https://codereview.chromium.org/613043002/diff/1/components/copresence/rpc/rpc_handler.cc#newcode411 components/copresence/rpc/rpc_handler.cc:411: for (const std::pair<std::string, std::vector<Message>>& map_entry : On 2014/10/01 03:48:32, ...
6 years, 2 months ago (2014-10-06 19:09:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613043002/20001
6 years, 2 months ago (2014-10-08 00:38:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f18aee0909c4ba8df96548f477805fe09948989f
6 years, 2 months ago (2014-10-08 01:33:08 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 01:34:09 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/853575ecd83de97fd334149a15b8fa399ef263a5
Cr-Commit-Position: refs/heads/master@{#298633}

Powered by Google App Engine
This is Rietveld 408576698