Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 613033002: Filled in missing dmSize, dmDriverExtra values for EnumDisplaySettings call (Closed)

Created:
6 years, 2 months ago by bajones
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Filled in missing dmSize, dmDriverExtra values for EnumDisplaySettings call These values should be filled in as specified by the MSDN documentation for the function: http://msdn.microsoft.com/en-us/library/windows/desktop/dd162611(v=vs.85).aspx BUG=418684 TBR=kbr@chromium.org Committed: https://crrev.com/b3b81dc60c55b48d2f49c8785914ed9acfb485e0 Cr-Commit-Position: refs/heads/master@{#297320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/gl/gl_surface_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613033002/1
6 years, 2 months ago (2014-09-29 23:46:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 54177b1cb487327b7ed3b6e1e70c805b8e5b184f
6 years, 2 months ago (2014-09-30 00:50:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b3b81dc60c55b48d2f49c8785914ed9acfb485e0 Cr-Commit-Position: refs/heads/master@{#297320}
6 years, 2 months ago (2014-09-30 00:51:48 UTC) #5
Ken Russell (switch to Gerrit)
Yikes. LGTM We really need to figure out how to unit test this platform-dependent code.
6 years, 2 months ago (2014-09-30 01:35:11 UTC) #6
bajones
On 2014/09/30 at 01:35:11, kbr wrote: > Yikes. LGTM > > We really need to ...
6 years, 2 months ago (2014-09-30 01:56:08 UTC) #7
Ken Russell (switch to Gerrit)
6 years, 2 months ago (2014-09-30 02:39:02 UTC) #8
Message was sent while issue was closed.
On 2014/09/30 01:56:08, bajones wrote:
> On 2014/09/30 at 01:35:11, kbr wrote:
> > Yikes. LGTM
> > 
> > We really need to figure out how to unit test this platform-dependent code.
> 
> Agreed, though I'm not sure how I could have caught this oversight with a
test.
> The function was performing correctly without these sizes set (which was
> probably just because they happened to be initializing to 0).

They almost certainly contained uninitialized information which would have blown
up at some point.

Powered by Google App Engine
This is Rietveld 408576698