Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 61303003: Fix linux_chromeos_clang compile for app_shell (Closed)

Created:
7 years, 1 month ago by James Cook
Modified:
7 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix linux_chromeos_clang compile for app_shell http://crrev.com/234634 changed aura::RootWindow so it isn't an aura::Window anymore. BUG=None TEST=compiles R=derat@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234703

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M apps/shell/app_shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
James Cook
7 years, 1 month ago (2013-11-13 01:35:56 UTC) #1
Daniel Erat
lgtm
7 years, 1 month ago (2013-11-13 01:36:35 UTC) #2
James Cook
7 years, 1 month ago (2013-11-13 01:47:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r234703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698