Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 612983004: Gather metrics on hosted app unlimitedStorage usage (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Gather metrics on hosted app unlimitedStorage usage BUG=416691 Committed: https://crrev.com/bc8979a1b57ae00eee1c730fdfc41f558a921055 Cr-Commit-Position: refs/heads/master@{#297323}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check result code #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -24 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 1 2 3 chunks +54 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/api/storage/local_value_store_cache.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Devlin
Jeffrey, PTAL. The approach I took in https://codereview.chromium.org/595683002/ was patently wrong, since hosted apps don't ...
6 years, 2 months ago (2014-09-29 20:57:22 UTC) #2
Jeffrey Yasskin
lgtm Sorry for not knowing the system well enough to catch that. https://codereview.chromium.org/612983004/diff/1/chrome/browser/extensions/extension_special_storage_policy.cc File chrome/browser/extensions/extension_special_storage_policy.cc ...
6 years, 2 months ago (2014-09-29 21:50:22 UTC) #3
Devlin
On 2014/09/29 21:50:22, Jeffrey Yasskin wrote: > lgtm > > Sorry for not knowing the ...
6 years, 2 months ago (2014-09-29 22:44:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612983004/20001
6 years, 2 months ago (2014-09-29 22:45:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/20889)
6 years, 2 months ago (2014-09-29 23:24:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612983004/30001
6 years, 2 months ago (2014-09-30 00:03:03 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:30001) as 5f4b1afd2880c9a0bfb45cc37181254d589580e2
6 years, 2 months ago (2014-09-30 01:08:57 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 01:10:08 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bc8979a1b57ae00eee1c730fdfc41f558a921055
Cr-Commit-Position: refs/heads/master@{#297323}

Powered by Google App Engine
This is Rietveld 408576698