Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 612933002: Fixed small error in how ChromeSyncShellTest was run. (Closed)

Created:
6 years, 2 months ago by mikecase (-- gone --)
Modified:
6 years, 2 months ago
Reviewers:
navabi1, jbudorick, navabi
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed small error in how ChromeSyncShellTest was run. BUG=406538 Committed: https://crrev.com/e935b2710b2552b1802f9396e3c7b7609f75696f Cr-Commit-Position: refs/heads/master@{#300727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (10 generated)
mikecase (-- gone --)
6 years, 2 months ago (2014-09-29 17:10:44 UTC) #2
jbudorick
lgtm
6 years, 2 months ago (2014-09-29 17:11:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612933002/1
6 years, 2 months ago (2014-09-29 17:13:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14123)
6 years, 2 months ago (2014-09-29 17:22:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612933002/1
6 years, 2 months ago (2014-09-29 19:44:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14182)
6 years, 2 months ago (2014-09-29 19:54:46 UTC) #11
mikecase (-- gone --)
6 years, 2 months ago (2014-09-29 20:24:12 UTC) #13
mikecase (-- gone --)
On 2014/09/29 20:24:12, mikecase wrote: Need an lgtm from the owner of bb_device_steps.
6 years, 2 months ago (2014-10-20 17:26:11 UTC) #15
mikecase (-- gone --)
On 2014/09/29 20:24:12, mikecase wrote: Need an lgtm from the owner of bb_device_steps.
6 years, 2 months ago (2014-10-20 17:26:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612933002/1
6 years, 2 months ago (2014-10-22 17:10:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/5254) linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/1541)
6 years, 2 months ago (2014-10-22 17:20:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612933002/1
6 years, 2 months ago (2014-10-22 18:19:38 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 19:25:44 UTC) #23
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 19:26:26 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e935b2710b2552b1802f9396e3c7b7609f75696f
Cr-Commit-Position: refs/heads/master@{#300727}

Powered by Google App Engine
This is Rietveld 408576698